(#1322) Try out a fix for test case 4f837671-6233-41f1-94e8-01174d1da7b8
#1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so that we can see things like library logs, or any additional logging we might add to help debug a test case.
… GitHub job running time limit I’m trying to understand the reason that the upload artifacts step is hung here [1], and I’m wondering if it’s because the job execution limit had already been reached by my script. [1] https://github.com/ably/ably-cocoa/runs/5979297645?check_suite_focus=true
To help with understanding issue described in f3af079.
I’m hoping this will reduce the upload time (more by reducing the number of files than the size).
https://stackoverflow.com/a/19845164 there's a broader problem of whether it's okay from an SDK logic point of view to reset this singleton that actually uses a shared storage (actually, that might be wrong - we’re using a new, fake storage each time)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if the failure of #1322 still happens.