Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to investigate test failures #1322

Closed
lawrence-forooghian opened this issue Apr 4, 2022 · 0 comments · Fixed by #1327
Closed

Document how to investigate test failures #1322

lawrence-forooghian opened this issue Apr 4, 2022 · 0 comments · Fixed by #1327
Assignees
@lawrence-forooghian

Comments

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Apr 4, 2022 •
edited by sync-by-unito bot
Loading

Split from #1279. Document the tools I've been using for #1309 and #1321 that will help us with #1279.

┆Issue is synchronized with this Jira Uncategorised by Unito
@lawrence-forooghian lawrence-forooghian linked a pull request Apr 5, 2022 that will close this issue
Add documentation about tools for investigating test failures #1327
Merged
@lawrence-forooghian lawrence-forooghian mentioned this issue Apr 13, 2022
Closed
lawrence-forooghian added a commit that referenced this issue Apr 27, 2022
@lawrence-forooghian
Add documentation about tools for investigating test failures
3cb8f3e 
This will help us investigate failures as we work on
#1279.

Closes #1322.
@lawrence-forooghian lawrence-forooghian mentioned this issue May 4, 2022
Closed
lawrence-forooghian added a commit that referenced this issue May 4, 2022
@lawrence-forooghian
Add locking to MockDeviceStorage
280a236 
As promised in e0ff029.

Together with de281bd and fbd5645, I believe this closes #1322 (various
crashes in
PushTests.test__008__LocalDevice__has_a_device_method_that_returns_a_LocalDevice,
which seemed to be related to threading).

Test case:
https://test-observability.herokuapp.com/repos/ably/ably-cocoa/test_cases/4f837671-6233-41f1-94e8-01174d1da7b8
lawrence-forooghian added a commit that referenced this issue May 5, 2022
@lawrence-forooghian
Add locking to MockDeviceStorage
6c3211f 
As promised in 3f78a12.

Together with de281bd and 214795f, I believe this closes #1322 (various
crashes in
PushTests.test__008__LocalDevice__has_a_device_method_that_returns_a_LocalDevice,
which seemed to be related to threading).

Test case:
https://test-observability.herokuapp.com/repos/ably/ably-cocoa/test_cases/4f837671-6233-41f1-94e8-01174d1da7b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lawrence-forooghian lawrence-forooghian

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add documentation about tools for investigating test failures ably/ably-cocoa
1 participant
@lawrence-forooghian