Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete device registration should not use the general-purpose endpoint #871

Merged
merged 1 commit into from
Jul 4, 2019

Conversation

ricardopereira
Copy link
Contributor

because it requires 'push-admin' permission and it will fail for 'push-subscribe' only key (Error: 401 "action not permitted").

 - because it requires 'push-admin' permission and it will fail for 'push-subscribe' only key

Error: 401 "action not permitted"
Copy link
Member

@paddybyers paddybyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@ricardopereira ricardopereira merged commit ec965ed into develop Jul 4, 2019
@ricardopereira ricardopereira deleted the fix-delete-device-registration branch July 4, 2019 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants