Added reference URL to leaking Sinks issue in push module

ably · Apr 27, 2022 · 35b784a · 35b784a
1 parent 243c66d
commit 35b784a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/src/platform/src/push_activation_events_internal.dart b/lib/src/platform/src/push_activation_events_internal.dart
@@ -5,7 +5,7 @@ import 'package:ably_flutter/ably_flutter.dart';
 /// package-private implementation of [PushActivationEvents]
 /// used internally by [Push] instances
 // FIXME: StreamControllers here may leak, we should add a `close()` method
-// like [PushNotificationEventsInternal.close()]
+// See: https://github.com/ably/ably-flutter/issues/382
 class PushActivationEventsInternal extends PushActivationEvents {
   /// [StreamController] used to handle onActivate events
   StreamController<ErrorInfo?> onActivateStreamController = StreamController();

diff --git a/lib/src/platform/src/push_notification_events_internal.dart b/lib/src/platform/src/push_notification_events_internal.dart
@@ -85,7 +85,8 @@ class PushNotificationEventsInternal implements PushNotificationEvents {
   }
 
   /// Used to close internal [StreamController] instances
-  // FIXME: This method is not called anywhere, and it probably should be
+  // FIXME: This method is not called anywhere
+  // See: https://github.com/ably/ably-flutter/issues/382
   void close() {
     onMessageStreamController.close();
     onNotificationTapStreamController.close();