Replace deprecated package:pedantic with package:flutter_lints and update analysis_options.yaml
#170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-xD
changed the title
ben-xD
changed the title
package:pedantic with package:flutter_lints and update analysis_options.yaml
github-actions
bot
temporarily deployed
to
staging/pull/170/dartdoc
github-actions
bot
temporarily deployed
to
staging/pull/170/dartdoc
github-actions
bot
temporarily deployed
to
staging/pull/170/dartdoc
github-actions
bot
temporarily deployed
to
staging/pull/170/dartdoc
Required once we switch our GitHub org default from 'permissive' to 'restricted'.
QuintinWillison
approved these changes
Sep 20, 2021
github-actions
bot
temporarily deployed
to
staging/pull/170/dartdoc
github-actions
bot
temporarily deployed
to
staging/pull/170/dartdoc
…-platform-method-timeouts
…orkflow-permissions
Remove timeouts for platform methods
github-actions
bot
temporarily deployed
to
staging/pull/170/dartdoc
Explicitly specify workflow `permissions` required to succeed when our org switches default access from 'permissive' to 'restricted'
github-actions
bot
temporarily deployed
to
staging/pull/170/dartdoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed deprecated pedantic package, added new flutter_lints package, and simplified
analysis_options.yamlto be more maintainable and readable.Closes #168
Also, closes #85
After doing the dependency changes, I checked which rules are already being added "included" by using the new lint package,
include: package:flutter_lints/flutter.yaml, and removed the lint rules which are already enabled by default. This reduces the content ofanalysis_options.yamlwithout changing any dart analysis warnings. This a combination of 3 files, flutter, recommended and core:This existing shopping-list/ kitchen-sink style of
analysis_options.dartis common when a lint package is not used/include'd. However, when we do use a convenient package like flutter-lints, it doesn't make sense to override them to be the same values.From this, I realised that the annoying issue I've been facing over the past 2 months leading to inconsistent styling in the code is down to this a lint rule that was turned on: #169, so I created that issue. To avoid noise in this PR, that will be a separate PR in the future.
I also had to format
test/rest/channels_test.dart. It seems like the Dart analyzer was not linting/ checking formatting in that file previously.