Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push Notifications documentation enhancement #177

Conversation

ben-xD
Copy link
Contributor

@ben-xD ben-xD commented Sep 21, 2021

No description provided.

@ben-xD ben-xD self-assigned this Sep 21, 2021
… into feature/push-notifications-documentation

# Conflicts:
#	PushNotifications.md
@github-actions github-actions bot temporarily deployed to staging/pull/177/dartdoc September 30, 2021 06:13 Inactive
Copy link
Contributor

@marklewin marklewin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions/comments

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
PushNotifications.md Outdated Show resolved Hide resolved
PushNotifications.md Outdated Show resolved Hide resolved
PushNotifications.md Outdated Show resolved Hide resolved
PushNotifications.md Outdated Show resolved Hide resolved
@QuintinWillison
Copy link
Contributor

Removing myself from the reviewers list on this PR as I can see that @marklewin has already provided comprehensive input. @ben-xD please feel free to land this PR once:

  1. You've addressed Mark's comments
  2. Mark's resolved those conversations to acknowledge that
  3. Mark's approved the PR

@QuintinWillison QuintinWillison removed their request for review October 4, 2021 08:28
ben-xD and others added 5 commits October 4, 2021 11:00
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
@github-actions github-actions bot temporarily deployed to staging/pull/177/dartdoc October 4, 2021 10:04 Inactive
…e/push-notifications-documentation' of github.com:ably/ably-flutter into feature/push-notifications-documentation

# Conflicts:
#	CONTRIBUTING.md
@github-actions github-actions bot temporarily deployed to staging/pull/177/dartdoc October 4, 2021 10:25 Inactive
@marklewin marklewin self-requested a review October 4, 2021 17:03
Copy link
Contributor

@marklewin marklewin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I've suggested some minor things that IMO need attention, for clarity.

PushNotifications.md Outdated Show resolved Hide resolved
PushNotifications.md Outdated Show resolved Hide resolved
PushNotifications.md Show resolved Hide resolved
PushNotifications.md Show resolved Hide resolved
PushNotifications.md Outdated Show resolved Hide resolved
ben-xD and others added 4 commits October 4, 2021 21:18
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
@github-actions github-actions bot temporarily deployed to staging/pull/177/dartdoc October 4, 2021 20:22 Inactive
…:ably/ably-flutter into feature/push-notifications-documentation

# Conflicts:
#	PushNotifications.md
Copy link
Contributor

@marklewin marklewin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ben-xD ben-xD merged commit 56d7eda into feature/push-notifications-dart Oct 5, 2021
@ben-xD ben-xD deleted the feature/push-notifications-documentation branch October 5, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants