New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push Notifications documentation enhancement #177
Push Notifications documentation enhancement #177
Conversation
…fications-documentation
…fications-documentation # Conflicts: # CONTRIBUTING.md
… into feature/push-notifications-documentation # Conflicts: # PushNotifications.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions/comments
Removing myself from the reviewers list on this PR as I can see that @marklewin has already provided comprehensive input. @ben-xD please feel free to land this PR once:
|
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
…tifications.md) and add screenshots
…e/push-notifications-documentation' of github.com:ably/ably-flutter into feature/push-notifications-documentation # Conflicts: # CONTRIBUTING.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I've suggested some minor things that IMO need attention, for clarity.
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
Co-authored-by: Mark Lewin <mark.lewin@ably.com>
…:ably/ably-flutter into feature/push-notifications-documentation # Conflicts: # PushNotifications.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.