Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: Move classes into separate files #189

Merged
merged 5 commits into from Nov 2, 2021
Merged

Refactoring: Move classes into separate files #189

merged 5 commits into from Nov 2, 2021

Conversation

ben-xD
Copy link
Contributor

@ben-xD ben-xD commented Oct 29, 2021

No description provided.

@github-actions github-actions bot temporarily deployed to staging/pull/189/dartdoc October 29, 2021 14:20 Inactive
@ben-xD ben-xD marked this pull request as draft October 29, 2021 14:20
@ben-xD ben-xD changed the title Small refactoring: Move classes into separate files Refactoring: Move classes into separate files Oct 29, 2021
@github-actions github-actions bot temporarily deployed to staging/pull/189/dartdoc October 29, 2021 14:24 Inactive
ikbalkaya
ikbalkaya suggested changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@ikbalkaya ikbalkaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a request on the hierarchical structure and a refactoring

lib/src/realtime/src/realtime_channel_options.dart Show resolved Hide resolved
lib/src/realtime/src/realtime_channels_interface.dart Show resolved Hide resolved
@ben-xD ben-xD marked this pull request as ready for review October 30, 2021 07:25
@github-actions github-actions bot temporarily deployed to staging/pull/189/dartdoc November 1, 2021 08:53 Inactive
@QuintinWillison QuintinWillison merged commit bd67ff9 into main Nov 2, 2021
@QuintinWillison QuintinWillison deleted the move-classes-into-files branch November 2, 2021 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikbalkaya ikbalkaya ikbalkaya approved these changes

@QuintinWillison QuintinWillison QuintinWillison approved these changes

@tiholic tiholic Awaiting requested review from tiholic

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ben-xD @ikbalkaya @QuintinWillison