Fix app crashing when receiving multiple push notifications #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-xD
added
the
bug
ikbalkaya
approved these changes
Nov 9, 2021
juleshyacinthe
pushed a commit
to juleshyacinthe/ably-flutter
that referenced
this pull request
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the app receives multiple push notifications, a crash occurs. This is because the broadcast receiver is not unregistered. In this fix, I refactor the code slightly, whilst making sure to unregister the receiver.
I also noticed the Rest client did not have a clientId set, so I did that here too instead of creating an entirely new PR.