Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/push UI improvement for debugging #218

Merged
merged 11 commits into from Nov 15, 2021

Conversation

ben-xD
Copy link
Contributor

@ben-xD ben-xD commented Nov 11, 2021

You can view a demo of this new UI in this slack message: https://ably-real-time.slack.com/archives/C012DA29VM0/p1636656460103300

@ben-xD ben-xD added the enhancement New feature or improved functionality. label Nov 11, 2021
@ben-xD ben-xD self-assigned this Nov 11, 2021
@github-actions github-actions bot temporarily deployed to staging/pull/218/dartdoc November 11, 2021 12:00 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/218/dartdoc November 11, 2021 14:30 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/218/dartdoc November 11, 2021 18:20 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/218/dartdoc November 11, 2021 18:39 Inactive
@ben-xD ben-xD requested review from QuintinWillison, ikbalkaya and tiholic and removed request for QuintinWillison and ikbalkaya November 11, 2021 18:47
@ben-xD ben-xD marked this pull request as ready for review November 11, 2021 18:48
@github-actions github-actions bot temporarily deployed to staging/pull/218/dartdoc November 11, 2021 18:49 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/218/dartdoc November 12, 2021 10:12 Inactive
@ben-xD ben-xD changed the base branch from main to bug/app-processes-is-null November 12, 2021 11:53
@github-actions github-actions bot temporarily deployed to staging/pull/218/dartdoc November 12, 2021 11:57 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/218/dartdoc November 12, 2021 12:01 Inactive
Copy link
Contributor

@ikbalkaya ikbalkaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from bug/app-processes-is-null to main November 15, 2021 08:39
…mprovement-for-debugging

# Conflicts:
#	android/src/main/java/io/ably/flutter/plugin/push/FirebaseMessagingReceiver.java
@github-actions github-actions bot temporarily deployed to staging/pull/218/dartdoc November 15, 2021 08:54 Inactive
@ben-xD ben-xD merged commit b242362 into main Nov 15, 2021
@ben-xD ben-xD deleted the enhancement/push-ui-improvement-for-debugging branch November 15, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improved functionality.
Development

Successfully merging this pull request may close these issues.

None yet

3 participants