Handle error cases on iOS correctly, and simplify code #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-xD
added
the
bug
github-actions
bot
temporarily deployed
to
staging/pull/221/dartdoc
tiholic
approved these changes
Nov 15, 2021
github-actions
bot
temporarily deployed
to
staging/pull/221/dartdoc
lukasz-szyszkowski
approved these changes
Nov 15, 2021
…/push/ios/handle-error-cases
Base automatically changed from
enhancement/push-ui-improvement-for-debugging
to
main
November 15, 2021 09:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the success and error handling for push. Its handling push activation (
didActivateAblyPush, deactivationdidDeactivateAblyPushand updatedidAblyPushRegistrationFailsuccess/error given by Ably Cocoa.In some cases, an error would be caused because we try to send a
FlutterErrorthrough aMethodChannel. This is not a type that can be serialized through aMethodChannel. Instead, this fix uses theARTErrorInfo, which has been used elsewhere to send back errors to platform side. It also avoids extraneous logic: mostly passing the errorInfo given by Ably Cocoa to the dart side.TLDR: Removing complexity and just passing errors (or
nil) directly.