Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setOptions to complete the Future (previously did not call result.success) and remove side effects in example app #222

Merged
merged 8 commits into from
Nov 22, 2021
Merged

Fix setOptions to complete the Future (previously did not call result.success) and remove side effects in example app #222

merged 8 commits into from
Nov 22, 2021

Commits on Nov 12, 2021

  1. Set _rest earlier to avoid not setting _rest state field at all.

    @ben-xD
    ben-xD committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    6532e0d View commit details
    Browse the repository at this point in the history

  2. Finish the platform call by calling result.success(null)

    @ben-xD
    ben-xD committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    daba886 View commit details
    Browse the repository at this point in the history

  3. Rename method to be consistent

    @ben-xD
    ben-xD committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    d8369dc View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2021

  1. Merge branch 'enhancement/ios/notification-in-remote-message' into ex… 

    …ample-app-refactor
    @ben-xD
    ben-xD committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    cb9cd7e View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. Merge branch 'enhancement/ios/notification-in-remote-message' into ex… 

    …ample-app-refactor
    @ben-xD
    ben-xD committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    b3c4416 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. Merge branch 'enhancement/ios/notification-in-remote-message' into ex… 

    …ample-app-refactor
    @ben-xD
    ben-xD committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    9124f1d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'enhancement/ios/notification-in-remote-message' into ex… 

    …ample-app-refactor
    @ben-xD
    ben-xD committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    81923dc View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2021

  1. Merge branch 'main' into example-app-refactor

    @QuintinWillison
    QuintinWillison committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    aac5431 View commit details
    Browse the repository at this point in the history