iOS: add notification in RemoteMessage
#224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-xD
requested review from
ikbalkaya,
QuintinWillison and
lukasz-szyszkowski
github-actions
bot
temporarily deployed
to
staging/pull/224/dartdoc
github-actions
bot
temporarily deployed
to
staging/pull/224/dartdoc
github-actions
bot
temporarily deployed
to
staging/pull/224/dartdoc
…ement/ios/notification-in-remote-message # Conflicts: # example/lib/ui/push_notifications/push_notifications_sliver.dart # lib/src/platform/src/platform.dart
ben-xD
changed the base branch from
main
to
enhancement/remove-prefer-relative-imports
…notification-in-remote-message
ben-xD
changed the base branch from
enhancement/remove-prefer-relative-imports
to
enhancement/platform-initializer
github-actions
bot
temporarily deployed
to
staging/pull/224/dartdoc
github-actions
bot
temporarily deployed
to
staging/pull/224/dartdoc
github-actions
bot
temporarily deployed
to
staging/pull/224/dartdoc
github-actions
bot
temporarily deployed
to
staging/pull/224/dartdoc
github-actions
bot
temporarily deployed
to
staging/pull/224/dartdoc
…notification-in-remote-message # Conflicts: # example/lib/ui/push_notifications/push_notifications_received_sliver.dart # example/lib/ui/push_notifications/push_notifications_sliver.dart
github-actions
bot
temporarily deployed
to
staging/pull/224/dartdoc
github-actions
bot
temporarily deployed
to
staging/pull/224/dartdoc
Use `[AnyHashable: Any]` instead of `NSDictionary` Co-authored-by: Łukasz Szyszkowski <47628502+lukasz-szyszkowski@users.noreply.github.com>
github-actions
bot
temporarily deployed
to
staging/pull/224/dartdoc
Co-authored-by: Łukasz Szyszkowski <47628502+lukasz-szyszkowski@users.noreply.github.com>
lukasz-szyszkowski
approved these changes
Nov 18, 2021
github-actions
bot
temporarily deployed
to
staging/pull/224/dartdoc
ikbalkaya
approved these changes
Nov 18, 2021
QuintinWillison
approved these changes
Nov 22, 2021
|
Oops, I pressed merge and assumed Github would protect me from merging when the tests are still running. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On iOS, the notification is kept inside the
userInfodictionary. To be consistent with Android, I extract the notification from this dictionary and pass it to the dart side.This allows the RemoteMessage to contain a
notificationif one is sent when the app is the foreground, background or terminated. If receiving a push notification in the example app, it will now change from left screenshot to right screenshot. Notice, the originalaps.alertobject in Notification data is still there. I will not modify thedataobject or remove the any title/body fields, to avoid backwards compatibility issues with Ably users or confusion.