Improve android logging: Remove unnecessary print statements, and use Log.w where necessary #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/228/dartdoc
ben-xD
force-pushed
the
enhancement/android/improve-logging
branch
from
1a74a64
to
a4c5dea
Compare
github-actions
bot
temporarily deployed
to
staging/pull/228/dartdoc
github-actions
bot
temporarily deployed
to
staging/pull/228/dartdoc
This reverts commit a246b9e.
github-actions
bot
temporarily deployed
to
staging/pull/228/dartdoc
lukasz-szyszkowski
approved these changes
Nov 19, 2021
QuintinWillison
approved these changes
Nov 22, 2021
|
It doesn't look like the failed check is caused by the contents of this PR, so I'm going to merge regardless. |
ben-xD
commented
Nov 22, 2021
| if (errorMessage != null) { | ||
| result.error("40000", String.format("Error from authCallback: %s", errorMessage), errorDetails); | ||
| } | ||
| result.error("40000", String.format("Error from authCallback: %s", errorMessage), errorDetails); |
There was a problem hiding this comment.
I should've removed this change in this PR, because this result.error usage is removed completely in a future PR: https://github.com/ably/ably-flutter/pull/231/files because it causes a bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.