Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialize LogLevel using constants #244

Merged
merged 5 commits into from Nov 29, 2021
Merged

Serialize LogLevel using constants #244

merged 5 commits into from Nov 29, 2021

Conversation

ben-xD
Copy link
Contributor

@ben-xD ben-xD commented Nov 20, 2021 •
edited

There was a TODO comment left in the code:

/// TODO(tiholic) convert [LogLevel] to enum and update encoder to pass
///  right numeric values to platform methods
class LogLevel {

This PR completes that TODO: Instead of using serializing logLevels to numbers, we use Strings, just like other enums in the codebase.

@ben-xD ben-xD added the enhancement New feature or improved functionality. label Nov 20, 2021
@ben-xD ben-xD self-assigned this Nov 20, 2021
@ben-xD ben-xD changed the base branch from main to enhancement/stop-using-deprecated.dart November 20, 2021 11:57
@ben-xD ben-xD mentioned this pull request Nov 20, 2021
Closed
@github-actions github-actions bot temporarily deployed to staging/pull/244/dartdoc November 20, 2021 12:00 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/244/dartdoc November 20, 2021 12:19 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/244/dartdoc November 23, 2021 08:40 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/244/dartdoc November 23, 2021 15:31 Inactive
ikbalkaya
ikbalkaya previously requested changes Nov 26, 2021
View reviewed changes
ios/Classes/codec/AblyFlutterReader.m Show resolved Hide resolved
lib/src/generated/platform_constants.dart Show resolved Hide resolved
Base automatically changed from enhancement/stop-using-deprecated.dart to main November 29, 2021 14:39
@QuintinWillison QuintinWillison dismissed ikbalkaya’s stale review November 29, 2021 14:53

Comments have been addressed and this reviewer is not available today to approve for themselves.

@QuintinWillison QuintinWillison merged commit 40f9578 into main Nov 29, 2021
@QuintinWillison QuintinWillison deleted the enhancement/log-level-serialization-2 branch November 29, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuintinWillison QuintinWillison QuintinWillison approved these changes

@lukasz-szyszkowski lukasz-szyszkowski lukasz-szyszkowski approved these changes

@tiholic tiholic Awaiting requested review from tiholic

@ikbalkaya ikbalkaya Awaiting requested review from ikbalkaya

Assignees

@ben-xD ben-xD

Labels
enhancement New feature or improved functionality.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ben-xD @ikbalkaya @QuintinWillison @lukasz-szyszkowski