Use Objective-C standard style for LogLevel enum #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-xD
requested review from
ikbalkaya,
QuintinWillison and
lukasz-szyszkowski
ben-xD
changed the base branch from
main
to
enhancement/log-level-serialization-2
github-actions
bot
temporarily deployed
to
staging/pull/246/dartdoc
github-actions
bot
temporarily deployed
to
staging/pull/246/dartdoc
lukasz-szyszkowski
approved these changes
Nov 22, 2021
github-actions
bot
temporarily deployed
to
staging/pull/246/dartdoc
github-actions
bot
temporarily deployed
to
staging/pull/246/dartdoc
ikbalkaya
approved these changes
Nov 26, 2021
QuintinWillison
approved these changes
Nov 29, 2021
Base automatically changed from
enhancement/log-level-serialization-2
to
main
November 29, 2021 15:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rename the
_Valueenum toCodecType. I also rename the cases in the CodecType enum to be the standard naming convention.This means when it used in Swift, it will be converted nicely: e.g.
CodecTypeAblyMessagein Objective-C will be translated/transpiled toCodecType.AblyMessagein Swift. Currently,AblyMessageCodecTypewill appear as _Value.ablyEventMessageCodecType in Swift, because the enum is declared astypedef NS_ENUM(UInt8, _Value).