Rename inconsistent methods to be more consistent #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-xD
requested review from
QuintinWillison,
tiholic and
lukasz-szyszkowski
…t/rename-client-store-methods
github-actions
bot
temporarily deployed
to
staging/pull/248/dartdoc
lukasz-szyszkowski
approved these changes
Nov 22, 2021
This reverts commit 18dde85.
github-actions
bot
temporarily deployed
to
staging/pull/248/dartdoc
ben-xD
changed the base branch from
enhancement/remove-unnecessary-classes
to
enhancement/log-level-enum
…ent-store-methods
github-actions
bot
temporarily deployed
to
staging/pull/248/dartdoc
QuintinWillison
approved these changes
Nov 29, 2021
|
It's clear that the Android 21 CI failure is unrelated to this change so I'm going to land this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have 2 equivalent methods for retrieiving rest and realtime clients, they are called
getRestandrealtimeWithHandle. In this PR, I rename them torestFrom(handle)andrestFrom(handle).