Explicitly check types of tokenDetails, instead of using macro which … #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…doesn't handle `NSNull` case
ben-xD
added
the
bug
QuintinWillison
approved these changes
Nov 24, 2021
lukasz-szyszkowski
approved these changes
Nov 24, 2021
ben-xD
changed the title
NSNull case) (2nd PR)
ben-xD
changed the title
NSNull case) (2nd PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've copied the fixes from #251 because there were too many PRs waiting to be reviewed before this bug could be fixed. We want to release this for a customer.
Please see #251
@lukasz-szyszkowski has already approved that one.