New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send deviceToken to Ably clients which already have been instantiated #277
Conversation
…ke in Ably Android
@lukasz-szyszkowski , I would like to change the pattern of calling a method in the singleton instance of For example, it would be nicer if the user did:
Could I get some help with improving this code? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We're pressured for time to get a release out. So, I'm going to land this work despite having not observed checks pass yet, due to the fact that the most recent commit should not fail CI and the preceding commit passed CI. |
This PR does 2 things:
didRegisterForRemoteNotifications
does not get called in Ably Flutter when running on iOS. This might happen due to method swizzling by other dependencies. This is a workaround for users who cannot fix the factdidRegisterForRemoteNotifications
is not being called in Ably Flutter.