Add workaround for firebase messaging #289
Conversation
ikbalkaya
added
the
documentation
Co-authored-by: Quintin Willison <q@qwuk.net>
Co-authored-by: Quintin Willison <q@qwuk.net>
README.md
Outdated
| @@ -88,6 +88,16 @@ Under the run/ debug configuration drop down menu, click `Edit Configurations... | |||
|
|
|||
| See [PushNotifications.md](PushNotifications.md) for detailed information on getting PN working with the example app. | |||
|
|
|||
| #### [Important Note regarding Firebase and Push Notifications](https://github.com/ably/ably-flutter/issues/226) | |||
There was a problem hiding this comment.
This readme actually has two sections with the same "Push Notifications" heading. 🙄
This one, and another one later on.
Perhaps that was the initial impetus for the creation of the dedicated, discrete document PushNotifications.md.
Regardless of reasons, the reality is that there are two places that could do with this information being visible... therefore my suggestion would be to move this new content to the dedicated document.
There was a problem hiding this comment.
I was aware of that but I thought this would be a bit more prominent if we have this on the original readme. And I also think that the readme here is in needs of shortening, Perhaps we can then move push notification section here. But I will move this to the separate file for now
README.md
Outdated
| @@ -88,6 +88,16 @@ Under the run/ debug configuration drop down menu, click `Edit Configurations... | |||
|
|
|||
| See [PushNotifications.md](PushNotifications.md) for detailed information on getting PN working with the example app. | |||
|
|
|||
| #### [Important Note regarding Firebase and Push Notifications](https://github.com/ably/ably-flutter/issues/226) | |||
|
|
|||
| If you are using the [official Firebase messaging library package](https://pub.dev/packages/firebase_messaging) along with this library, then you must add the following block to your Android application's manifest file within the `application` element. This is a workaround that prevents a conflict rising from the two libraries installed together. | |||
There was a problem hiding this comment.
| If you are using the [official Firebase messaging library package](https://pub.dev/packages/firebase_messaging) along with this library, then you must add the following block to your Android application's manifest file within the `application` element. This is a workaround that prevents a conflict rising from the two libraries installed together. | |
| If you are using the [official Firebase messaging library package](https://pub.dev/packages/firebase_messaging) along with this library, then you must add the following block to your Android application's manifest file within the `application` element. This is a workaround that prevents a conflict that happens when the two libraries are installed together. |
|
Sorry, @ikbalkaya, I've spotted things on my second pass of this PR that I should have spotted the first time around... including something I introduced in one of my suggestions. My bad! 🤦 |
This PR adds a warning for users who use Firebase messaging library along with Ably library