Update to ably-cocoa v.1.2.9
#299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried to follow the steps that had worked for me a few days ago, as detailed in the opening comment here: #293 However, I got some odd CocoaPods errors. I ended up following these instructions (it's `trunk`) which got me there for the example directory but was still failing for test_integration: https://stackoverflow.com/a/34526412/392847 So, I ended up picking the changes that the pod tool had applied to the lock file in the example directory and manually transferring those over to the test_integration lock file. Not ideal - so there's more to be understood here as this is not sustainable.
QuintinWillison
requested review from
ikbalkaya,
lawrence-forooghian and
lukasz-szyszkowski
lukasz-szyszkowski
approved these changes
Jan 20, 2022
ikbalkaya
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #296.
There were complications when I worked on this locally, though broadly I was following the procedure described here: #293