Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checked for nullity of activation / deactivation results #303

Merged
merged 10 commits into from Jan 24, 2022
Merged

Checked for nullity of activation / deactivation results #303

merged 10 commits into from Jan 24, 2022

Commits on Jan 24, 2022

  1. Checked for nullity of activation / deactivation results

    @ikbalkaya
    ikbalkaya committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    a6c63e3 View commit details
    Browse the repository at this point in the history

  2. Added logs to affirm the existence of results

    @ikbalkaya
    ikbalkaya committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    0e8bacd View commit details
    Browse the repository at this point in the history

  3. Added more clarity to logs associating them with PUSH_DEACTIVATE_ACTI… 

    …ON and PUSH_ACTIVATE_ACTION
    @ikbalkaya
    ikbalkaya committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    6040d1f View commit details
    Browse the repository at this point in the history

  4. Passed resultForDeactivate to returnMethodCallResult on PUSH_DEACTIVA… 

    …TE_ACTION
    @ikbalkaya
    ikbalkaya committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    20cf018 View commit details
    Browse the repository at this point in the history

  5. Update debug log for PUSH_DEACTIVATE_ACTION 

    Co-authored-by: Quintin Willison <q@qwuk.net>
    @ikbalkaya @QuintinWillison
    ikbalkaya and QuintinWillison committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    61e868d View commit details
    Browse the repository at this point in the history

  6. Update debug log for PUSH_ACTIVATE_ACTION 

    Co-authored-by: Quintin Willison <q@qwuk.net>
    @ikbalkaya @QuintinWillison
    ikbalkaya and QuintinWillison committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    1b44309 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into bug/android_push_npe_channel

    @QuintinWillison
    QuintinWillison committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    63f1616 View commit details
    Browse the repository at this point in the history

  8. Added whitespaces for if/else blocks for cases PUSH_ACTIVATE_ACTION a… 

    …nd PUSH_DEACTIVATE_ACTION
    @ikbalkaya
    ikbalkaya committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    1515418 View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'origin/bug/android_push_npe_channel' in… 

    …to bug/android_push_npe_channel

# Conflicts:
#	android/src/main/java/io/ably/flutter/plugin/push/PushActivationEventHandlers.java
    @ikbalkaya
    ikbalkaya committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    93ecf46 View commit details
    Browse the repository at this point in the history

  10. Added whitespaces for if/else blocks for cases PUSH_ACTIVATE_ACTION a… 

    …nd PUSH_DEACTIVATE_ACTION
    @ikbalkaya
    ikbalkaya committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    f9534e5 View commit details
    Browse the repository at this point in the history