Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android embedding v2 #312

Merged
merged 6 commits into from Feb 7, 2022
Merged

Android embedding v2 #312

merged 6 commits into from Feb 7, 2022

Conversation

ikurek
Copy link
Contributor

@ikurek ikurek commented Feb 4, 2022

This PR is a migration supposed to solve #311, by fully adapting Flutter Android Embedding V2 following the official migration guide. Besides the migration itself, additional compatibility changes include:

  • Forced Kotlin version for example app (Flutter recommends setting 1.5.31)
  • Changed Android target and compile SDK versions to latest (32)
  • Updated a few Flutter dependencies for example app
  • Updated test dependency version for dart library
  • Set Android application as exported in Manifest file, to comply with Android S requirements

@ikurek ikurek self-assigned this Feb 4, 2022
@ikurek ikurek changed the title Fix/android embedding v2 Android embedding v2 Feb 4, 2022
@github-actions github-actions bot temporarily deployed to staging/pull/312/dartdoc February 4, 2022 12:35 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/312/dartdoc February 4, 2022 12:53 Inactive
KacperKluka
KacperKluka reviewed Feb 4, 2022
View reviewed changes
Copy link

@KacperKluka KacperKluka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I'm not sure about one thing 😁

example/android/app/build.gradle Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to staging/pull/312/dartdoc February 4, 2022 13:19 Inactive
KacperKluka
KacperKluka approved these changes Feb 4, 2022
View reviewed changes
Copy link

@KacperKluka KacperKluka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ikurek ikurek added bug Something isn't working. It's clear that this does need to be fixed. maintenance labels Feb 7, 2022
QuintinWillison
QuintinWillison approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@QuintinWillison QuintinWillison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'm keen to get this landed, in order to re-achieve green CI in the main branch. 🚀

@QuintinWillison QuintinWillison merged commit 852fd71 into main Feb 7, 2022
@QuintinWillison QuintinWillison deleted the fix/android-embedding-v2 branch February 7, 2022 13:49
@QuintinWillison QuintinWillison mentioned this pull request Feb 8, 2022
Closed
@ikurek ikurek mentioned this pull request Feb 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuintinWillison QuintinWillison QuintinWillison approved these changes

@KacperKluka KacperKluka KacperKluka approved these changes

@ikbalkaya ikbalkaya Awaiting requested review from ikbalkaya

Assignees

@ikurek ikurek

Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ikurek @QuintinWillison @KacperKluka