AblyInstanceStore concurrency
#321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing reserveClientHandle() was assumed to always be called from the same thread, with no logical link to the createRest() and createRealtime() that were being called after it. I'm honestly not sure if this was a bug that was being experienced right now, but the assumptions that the existing AblyMethodCallHandler implementation were making were likely to become an issue for us later on as the codebase grows, so I wanted to get this fixed now.
I considered have a discrete lock for paginated results but kept on circling back to the implications of the work done by the reset() method. So, on balance, I can't envisage a scenario where any of these methods take such a long time with the lock obtained that this change would have a measurable impact on performance.
KacperKluka
reviewed
Feb 8, 2022
android/src/main/java/io/ably/flutter/plugin/AblyInstanceStore.java
Outdated
Show resolved
Hide resolved
|
Converting this PR back to Draft state while I work on @KacperKluka's review comments. |
I was reinventing the wheel.
…the Ably instance store. I had overlooked the requirement to actually set the handle as used when it had been used, being the whole point as to why this class was there!
ikurek
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #308.