Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified platform method invocations #371

Merged
merged 8 commits into from
Apr 21, 2022
Merged

Conversation

ikurek
Copy link
Contributor

@ikurek ikurek commented Apr 14, 2022

This should resolve #359. In scope of this pull request:

  • All parameters passed to platform instances are now wrapped in AblyMessage. This makes it easier to handle them on native side, and the communication from Dart to platform SDKs is more consistent
  • Parameters of platform methods are now always a Map of values. Previously, these methods accepted Object which led to inconsistent behavior (for example, Crypto.generateRandomKey did not use a map with the generated TxCryptoGenerateRandomKey.keyLength value, but rather passed a raw int value)
  • invoke method was altered to allow passing handle value besides the parameters, and invokeRaw was removed, since it became unnecessary.

@ikurek ikurek self-assigned this Apr 14, 2022
@github-actions github-actions bot temporarily deployed to staging/pull/371/dartdoc April 14, 2022 16:51 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/371/dartdoc April 14, 2022 17:18 Inactive
Copy link
Contributor

@QuintinWillison QuintinWillison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll admit I've only given this a brief, light review - but on a skim read, nothing looks obviously out of place. Thanks. 😁

@ikurek ikurek merged commit b001348 into main Apr 21, 2022
@ikurek ikurek deleted the fix/platform-method-invocations branch April 21, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Use consistent type for platform method parameters
3 participants