Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose error info in AblyException toString #447

Merged
merged 4 commits into from Oct 13, 2022
Merged

Expose error info in AblyException toString #447

merged 4 commits into from Oct 13, 2022

Conversation

davyskiba
Copy link
Contributor

Exposing full 'ErrorInfo' contents in 'AblyException.toString()' primarily to expose 'href'

Resolves #441

@github-actions github-actions bot temporarily deployed to staging/pull/447/dartdoc October 5, 2022 13:36 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/447/dartdoc October 5, 2022 13:48 Inactive
JakubJankowski
JakubJankowski approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@JakubJankowski JakubJankowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

ikbalkaya
ikbalkaya approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@ikbalkaya ikbalkaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any additional comment on this as code looks good to me, but I think Quintin's question is an important one to answer.

@github-actions github-actions bot temporarily deployed to staging/pull/447/dartdoc October 7, 2022 13:58 Inactive
@davyskiba davyskiba merged commit a417afd into main Oct 13, 2022
@davyskiba davyskiba deleted the expose_href_in_exception branch October 13, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikbalkaya ikbalkaya ikbalkaya approved these changes

@arturjaworski arturjaworski arturjaworski approved these changes

@QuintinWillison QuintinWillison QuintinWillison approved these changes

@JakubJankowski JakubJankowski JakubJankowski approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose href from ErrorInfo in bubbled exceptions
5 participants
@davyskiba @ikbalkaya @arturjaworski @QuintinWillison @JakubJankowski