Add numbers strategy for Gson to prevent changing int to double #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenpearson
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
Hey @Afur, thanks for the contribution (and sorry for the delayed response)! The code change LGTM, we're just in the process of understanding customer impact on this, our current plan is to include it in an ably-flutter release early next week 🙂
ikbalkaya
approved these changes
Apr 27, 2023
|
@ikbalkaya Hey, this issue still exists in latest version because code with fix that I've provided is not on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue described here: #461