Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: recipient deserialization problem #492

Merged
merged 1 commit into from Nov 2, 2023
Merged

fix: recipient deserialization problem #492

merged 1 commit into from Nov 2, 2023

Conversation

ttypic
Copy link
Contributor

@ttypic ttypic commented Nov 2, 2023 •
edited by jira bot

Issue #491
Resolves SDK-3919

@ttypic ttypic requested a review from sacOO7 November 2, 2023 13:41
sacOO7
sacOO7 approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@sacOO7 sacOO7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sacOO7
Copy link
Collaborator

sacOO7 commented Nov 2, 2023

I had a question though, It shouldn't throw exception for key being object, can you just double check that

@ttypic ttypic merged commit 723c679 into main Nov 2, 2023
8 checks passed
@ttypic ttypic deleted the fix-device-push-ios branch November 2, 2023 18:32
@stmoreau stmoreau mentioned this pull request Nov 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sacOO7 sacOO7 sacOO7 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ttypic @sacOO7