-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RTN2g #210
Add RTN2g #210
Conversation
I mean, But whatever, that doesn't matter all that much, the most important thing is that it's identifying itself somehow |
This isn't right according to RSC7b, which says that for |
@tcard @SimonWoolf I checked the spec you are right. I have made the change to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SimonWoolf Do you need this backported to the 1.1 branch (main) and released?
Given we're releasing ably-go 1.2 soon, do we expect significant numbers people to be shunning that and upgrading only to the newest 1.1.x? If yes then yes, else no. |
Given 1.2 will come not just with an API upgrade but with major, critical features, I'd expect we'll be pushy about migrating users to 1.2. |
To track old ably-go versions which set `X-Ably-Lib` to `ably-go-<version>` rather than `go-<version>`, which was changed in Nov 2020: ably/ably-go#210 Fixes #179. Signed-off-by: Lewis Marshall <lewis.marshall@ably.com>
@SimonWoolf the library name is
ably-go
and not justgo
so thelib
query param will contain something likeably-go-1.1.5
instead ofgo-1.1.5