Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed init_default_log_output_stream test on Windows #209

Merged
merged 1 commit into from
Oct 31, 2016
Merged

Fixed init_default_log_output_stream test on Windows #209

merged 1 commit into from
Oct 31, 2016

Conversation

psolstice
Copy link
Contributor

No description provided.

@paddybyers
Copy link
Member

LGTM.

@paddybyers paddybyers merged commit 66454d2 into ably:master Oct 31, 2016
@paddybyers
Copy link
Member

Thanks.

BTW I suggest that you create branches for the pull requests you create instead of using your master, so they can be reviewed and landed in any order, and your master can always track upstream master.

@psolstice
Copy link
Contributor Author

Sure, I used to work with feature branches. This one was trivial so I skipped this step. Next time I'll create a new branch

@paddybyers
Copy link
Member

This one was trivial so I skipped this step. Next time I'll create a new branch

Yes, but you can't be sure we'll get around to reviewing it and landing it in the order you expect :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psolstice @paddybyers