Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use exception instead of deprecation notice #376

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Use exception instead of deprecation notice #376

merged 1 commit into from
Mar 19, 2018

Conversation

funkyboy
Copy link
Contributor

Fix #139

paddybyers
paddybyers reviewed Mar 16, 2018
View reviewed changes
lib/src/main/java/io/ably/lib/types/BaseMessage.java Outdated
@@ -131,11 +131,7 @@ public void encode(ChannelOptions opts) throws AblyException {
encoding = ((encoding == null) ? "" : encoding + "/") + "utf-8";
}
} else if(!(data instanceof byte[])) {
if (opts != null && opts.encrypted) {
throw AblyException.fromErrorInfo(new ErrorInfo("Invalid message data or encoding", 400, 40013));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely we also need a whitespace change here as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. Fixed.

@funkyboy
Copy link
Contributor Author

@paddybyers Yup. Fixed.

@funkyboy funkyboy merged commit 063c323 into develop Mar 19, 2018
@funkyboy funkyboy deleted the fix-deprecation-notice branch March 19, 2018 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paddybyers paddybyers paddybyers approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@funkyboy @paddybyers