Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert enum variable naming to lowercase #94

Merged
merged 1 commit into from Feb 15, 2016
Merged

Convert enum variable naming to lowercase #94

merged 1 commit into from Feb 15, 2016

Conversation

gokhanbarisaker
Copy link
Contributor

Resolves #90

@mattheworiordan
Copy link
Member

LGTM, although I see you applied your lowercase to all Enums. I am happy with this, but @paddybyers should give his thumbs up.

@paddybyers
Copy link
Member

I didn't expect that everything would change, but consistent is good, so LGTM.

mattheworiordan added a commit that referenced this pull request Feb 15, 2016
@mattheworiordan
Merge pull request #94 from gokhanbarisaker/enum-naming
603d788 
Convert enum variable naming to lowercase
@mattheworiordan mattheworiordan merged commit 603d788 into ably:master Feb 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gokhanbarisaker @mattheworiordan @paddybyers