Lower case PresenceMessage.Action enum

[mattheworiordan]

If you look at ConnectionState, the enums are all lowercase allowing something like:

switch (state) {
  case connected:
  case failed:
}

and the following:

connection.on(ConnectionState.connected, listener) { ... }

Same applies for ChannelState.

However, PresenceMessage.Action uses upper case making the API interface for devs consistent. For example, a user will now need to do the following (once #21 is resolved):

presence.subscribe(PresenceMessage.Action.ENTER, listener) { ... }

and

switch (action) {
  case ENTER:
  case LEAVE:
}

I believe we should aim for consistency in these public enums and should probably just go lowercase.

WDYT @paddybyers?

[paddybyers]

WDYT

I don't feel strongly about it. The enum values are constants so the usual Java naming convention is that they're upper case, but it's a breakable rule I think. Internal consistency in the java lib has to have a higher priority, and consistency with other libs is also a consideration, although not an overriding priority.

I'm ok for them to change to lower case.

[mattheworiordan]

Ok, thanks, lets change to lower then