Skip to content

Commit

Permalink
Merge pull request #704 from ably/feature/es6-modules
Browse files Browse the repository at this point in the history
Use ES6 Modules
  • Loading branch information
owenpearson committed Feb 16, 2021
2 parents e9f0e59 + 7b80375 commit 69b621a
Show file tree
Hide file tree
Showing 79 changed files with 5,648 additions and 3,389 deletions.
7 changes: 7 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
node_modules
browser/static
spec
resources
test
tools
webpack.config.js
15 changes: 15 additions & 0 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"env": {
"es6": true,
"node": true,
"browser": true
},
"rules": {
"no-undef": "error",
"comma-dangle": ["error", "never"],
"eol-last": "error"
},
"parserOptions": {
"sourceType": "module"
}
}
18 changes: 18 additions & 0 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
on:
pull_request:
push:
branches:
- main

jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Use Node.js 14.x
uses: actions/setup-node@v1
with:
node-version: 14.x
- run: npm ci
- run: npm run lint
- run: npm run check-closure-compiler
19 changes: 19 additions & 0 deletions .github/workflows/test-karma.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
on:
pull_request:
push:
branches:
- main

jobs:
test-karma-firefox:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
with:
submodules: 'recursive'
- name: Use Node.js 14.x
uses: actions/setup-node@v1
with:
node-version: 14.x
- run: npm ci
- run: xvfb-run -a npm run test:karma
21 changes: 5 additions & 16 deletions .github/workflows/actions.yml → .github/workflows/test-node.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
name: ably-js CI

on: [push]
on:
pull_request:
push:
branches:
- main

jobs:
test-node:
Expand All @@ -20,16 +22,3 @@ jobs:
- run: npm run test:mocha
env:
CI: true

test-karma-firefox:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
with:
submodules: 'recursive'
- name: Use Node.js 14.x
uses: actions/setup-node@v1
with:
node-version: 14.x
- run: npm ci
- run: xvfb-run -a npm run test:karma
Loading

0 comments on commit 69b621a

Please sign in to comment.