Fix rest fallback behavior does not conform to the spec #1717
Assignees
Labels
bug
Something isn't working. It's clear that this does need to be fixed.
Comments
VeskeR
added
the
bug
VeskeR
added a commit
that referenced
this issue
Apr 5, 2024
Add missing `httpMaxRetryDuration` value to Defaults.TIMEOUTS Resolves #1717
VeskeR
added a commit
that referenced
this issue
Apr 17, 2024
Add missing `httpMaxRetryDuration` value to Defaults.TIMEOUTS Resolves #1717
VeskeR
added a commit
that referenced
this issue
Apr 17, 2024
Add missing `httpMaxRetryDuration` value to Defaults.TIMEOUTS Resolves #1717
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
httpMaxRetryDurationin its fallback mechanism (but it should based on TO3l6):https://github.com/ably/ably-js/blob/main/src/common/types/http.ts#L195-L209
we only timeout per request using
httpRequestTimeoutvalue and have a list of fallback hosts to retry with based onhttpMaxRetryCounthttpRequestTimeoutis set by default to 15s in code, when it should be 10s as per spec TO3l4. Also, in type declarations we wrongly say it's set to 10s by default.httpMaxRetryDurationin public type declarations saying its default value is 15s, even though we don't use this parameter anywhere.See intenal slack thread for more context.
┆Issue is synchronized with this Jira Task by Unito
The text was updated successfully, but these errors were encountered: