Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECO-4721] Fix rest fallback behavior #1721

Merged
merged 3 commits into from Apr 17, 2024
Merged

Conversation

VeskeR
Copy link
Contributor

@VeskeR VeskeR commented Apr 5, 2024

Resolves #1717

Fixes incorrect default value for httpRequestTimeout client option. It should be 10 seconds according to TO3l4.
Implements missing httpMaxRetryDuration functionality and adds tests for it per TO3l6.

@github-actions github-actions bot temporarily deployed to staging/pull/1721/features April 5, 2024 10:55 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1721/bundle-report April 5, 2024 10:56 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1721/typedoc April 5, 2024 10:56 Inactive
@VeskeR VeskeR force-pushed the 1717/fix-rest-fallback-behavior branch from 76a77af to c1f119c Compare April 5, 2024 10:58
@github-actions github-actions bot temporarily deployed to staging/pull/1721/features April 5, 2024 10:58 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1721/bundle-report April 5, 2024 10:58 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1721/typedoc April 5, 2024 10:59 Inactive
@VeskeR VeskeR marked this pull request as ready for review April 5, 2024 11:55
src/common/types/http.ts Outdated Show resolved Hide resolved
test/rest/fallbacks.test.js Outdated Show resolved Hide resolved
It should be 10 seconds according to TO3l4
@VeskeR VeskeR force-pushed the 1717/fix-rest-fallback-behavior branch from c1f119c to d722520 Compare April 17, 2024 11:54
@github-actions github-actions bot temporarily deployed to staging/pull/1721/features April 17, 2024 11:54 Inactive
Add missing `httpMaxRetryDuration` value to Defaults.TIMEOUTS

Resolves #1717
@github-actions github-actions bot temporarily deployed to staging/pull/1721/typedoc April 17, 2024 11:54 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1721/bundle-report April 17, 2024 11:55 Inactive
@VeskeR VeskeR force-pushed the 1717/fix-rest-fallback-behavior branch from d722520 to be6a9ac Compare April 17, 2024 11:55
@github-actions github-actions bot temporarily deployed to staging/pull/1721/features April 17, 2024 11:55 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1721/bundle-report April 17, 2024 11:56 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1721/typedoc April 17, 2024 11:56 Inactive
@VeskeR VeskeR merged commit bf2bfcc into main Apr 17, 2024
12 checks passed
@VeskeR VeskeR deleted the 1717/fix-rest-fallback-behavior branch April 17, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix rest fallback behavior does not conform to the spec
2 participants