Feature/rea 1808 use separate channel object #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to the active channel, we need to avoid conflicts.
We store the current active set of members in the hashring.
Messages can be delivered more than once during a consumer group rescaling event, so deduplicate the results when checking the end condition.
github-actions
bot
temporarily deployed
to
staging/pull/1655/features
github-actions
bot
temporarily deployed
to
staging/pull/1655/typedoc
github-actions
bot
temporarily deployed
to
staging/pull/1655/bundle-report
VeskeR
approved these changes
Mar 1, 2024
The Channels object used by the ChannelGroup for internal channel operations no longer shares the same object exposed on the client via the .channels() method. This is to ensure that independent usage of an individual channel that happens to be included in a channel group is not impacted by its usage in the channel group.
Now that we can correctly handle a channel group and channel being used independently from the same client, this tidies up the leave test to remove the additional client previously needed.
mschristensen
force-pushed
the
feature/REA-1808-use-separate-channel-object
branch
from
08259c4
to
2193fa0
Compare
mschristensen
merged commit 2906280
into
experimental-v2/channel-and-consumer-group
4 of 12 checks passed
This was referenced Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1651