Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .editorconfig for basic IDE configuration settings #150

Merged
merged 1 commit into from
Nov 13, 2018

Conversation

mattheworiordan
Copy link
Member

Copy link
Member

@paddybyers paddybyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

charset = utf-8

[*.md]
trim_trailing_whitespace = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a curiosity. Why is it false for markdown files?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. I don't know, I saw this in a few other examples I looked at. I can only imagine that for things like code blocks, you may for some reason want to force additional trailing white space. But given I can't think of a good reason for this, I should really remove.

@mattheworiordan mattheworiordan merged commit 9ef7a4d into master Nov 13, 2018
@mattheworiordan mattheworiordan deleted the editorconfig branch November 13, 2018 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants