Fallback host improvements #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs Ably.configure_lib_variant = 'rest' to be added to the REST lib
Addresses #RSC15b, #TO3k6, #TO3k7
See #RTN17b, #TO3k6, #TO3k7
mattheworiordan
force-pushed
the
fallback-host-improvements
branch
from
5c4b1ff
to
2bd2eba
Compare
Partially fixes #95
I suspected that the mocking of failures may have meant things were passing when they shouldn’t have. Turns out that’s not the case and everything does work.
mattheworiordan
force-pushed
the
fallback-host-improvements
branch
from
2bd2eba
to
9eeb836
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@SimonWoolf for when you're back from holiday, a few fixes including some for the fallback host functionality, see #95