Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat ESLint warnings as errors #75

Merged
merged 2 commits into from
May 4, 2023
Merged

Treat ESLint warnings as errors #75

merged 2 commits into from
May 4, 2023

Conversation

lawrence-forooghian
Copy link
Collaborator

This fixes the current linter warnings and causes CI to fail in the case of linter warnings.

@lawrence-forooghian lawrence-forooghian mentioned this pull request May 4, 2023
Merged
owenpearson
owenpearson approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

@lawrence-forooghian lawrence-forooghian merged commit eec1421 into main May 4, 2023
2 checks passed
@lawrence-forooghian lawrence-forooghian deleted the treat-ESLint-warnings-as-errors branch May 4, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenpearson owenpearson owenpearson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lawrence-forooghian @owenpearson