Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling of crash report without test failure #74

Merged
merged 1 commit into from
May 4, 2023
Merged

Better handling of crash report without test failure #74

merged 1 commit into from
May 4, 2023

Conversation

lawrence-forooghian
Copy link
Collaborator

Return a 400 response with a useful error message.

Part of #73.

@lawrence-forooghian
Better handling of crash report without test failure
239ab62 
Return a 400 response with a useful error message.

Part of #73.
owenpearson
owenpearson approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks (we really ought to fix those linter warnings btw)

@lawrence-forooghian lawrence-forooghian merged commit 96fc7bc into main May 4, 2023
2 checks passed
@lawrence-forooghian lawrence-forooghian deleted the improve-errors branch May 4, 2023 11:41
@lawrence-forooghian
Copy link
Collaborator Author

we really ought to fix those linter warnings btw

Thanks @owenpearson, opened #75 for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenpearson owenpearson owenpearson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lawrence-forooghian @owenpearson