Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor [xb] - constantly "foobar" in let #294

Closed
rprimus opened this issue Aug 6, 2016 · 5 comments
Closed

refactor [xb] - constantly "foobar" in let #294

rprimus opened this issue Aug 6, 2016 · 5 comments

Comments

@rprimus
Copy link

rprimus commented Aug 6, 2016

Sat Aug 6 17:39:39 BST 2016

GNU Emacs 24.5.1 (x86_64-apple-darwin15.4.0, NS apple-appkit-1404.41) of 2016-01-16

Followed along with YT video posted yesterday, (working on ivy.el) using lispy-20160804.537 from elpa.

Using 'xb' at the point where you first it, I get:

            (if (> (+ (mod (+ (let ((foobar (length n-str)))
                                           ) (length d-str)) (window-width))

with the cursor before the new close paren on the last line.
I can type in a new name at this point, however the foobar does not change.

Is there some other configuration required to have the same multi-cursor ability (as demonstrated in the video)?

@rprimus rprimus changed the title refactor [xb] - constant "foobar" in refactor [xb] - constantly "foobar" in let Aug 6, 2016
@abo-abo
Copy link
Owner

abo-abo commented Aug 6, 2016

Do you have iedit installed?

@rprimus
Copy link
Author

rprimus commented Aug 6, 2016

On Sat, Aug 06, 2016 at 10:00:13AM -0700, Oleh Krehel wrote:

Do you have iedit installed?

Sat 6 Aug 2016 18:14:28 BST

I have iedit-20160728.1951 installed.

I have tried with ivy-mode enabled (as in video) as well as iedit-mode (based on your question).

What mode does the * in your mode-line represent?

-primus (Train yourself and be your own master.)
"First solve the problem, then code!"
Narrowness of experience leads to narrowness of imagination.
http://www.catb.org/esr/faqs/smart-questions.html
http://www.chiark.greenend.org.uk/~sgtatham/bugs.html

GPG Key: DB3FB476
Key fingerprint: B0FB C67E 2E7E 7032 7FE6 7FBC 28E9 2848 DB3F B476

@abo-abo abo-abo closed this as completed in dd2e314 Aug 6, 2016
@abo-abo
Copy link
Owner

abo-abo commented Aug 6, 2016

Thanks, apparently the newer Iedit takes different prefix args than before.

@rprimus
Copy link
Author

rprimus commented Aug 6, 2016

Sat Aug 6 19:30:57 BST 2016

Just tested with make elisp.
All is fine!!

FYI, had to modify lispy-tags by adding (require 'cl-lib) as error generated saying:
Symbol's function definition is void: cl-defstruct

Cheers for the quick turnaround!!

abo-abo added a commit that referenced this issue Aug 6, 2016
@abo-abo
Copy link
Owner

abo-abo commented Aug 6, 2016

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants