New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel-ag doesn't work with TRAMP #669

Closed
bricewge opened this Issue Sep 13, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@bricewge

bricewge commented Sep 13, 2016

For example doing counsel-ag with a buffer containing the file/ssh:myserver:/etc/apt/sources.list will result on a search on /home/username/ on the localhost machine. This also appear when the buffer display a file opened as sudo on the localhost.

The expected behaviour would be to search from the opened file on the remote machine if ag is installed or as sudo if the file was openned as sudo.

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Sep 13, 2016

Does ag even work on a remote machine?

@bricewge

This comment has been minimized.

bricewge commented Sep 13, 2016

I don't thinks so. But it shouldn't be an issue since TRAMP give the ability to run commands on the remote box.
It looks like this behaviour is already present in ag.el.

@abo-abo abo-abo closed this in 870112e Sep 13, 2016

@abo-abo

This comment has been minimized.

Owner

abo-abo commented Sep 13, 2016

Please test, ag needs to be installed on the remote box.

@bricewge

This comment has been minimized.

bricewge commented Sep 13, 2016

You fixed it. And you were blazing fast.
Thanks a lot for your work en emacs packages, they are awesome !

jeberger added a commit to jeberger/swiper that referenced this issue Oct 10, 2017

counsel.el: Allow async commands on Tramp buffers
Makes `counsel--async-command` work on remote buffers. This removes
the need for the workaround introduced in `counsel-ag-function` with
abo-abo#669 and should fix similar issues in other commands or plugins.

Fixes abo-abo#1229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment