Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

counsel-ag doesn't work with TRAMP #669

Closed
bricewge opened this issue Sep 13, 2016 · 4 comments
Closed

counsel-ag doesn't work with TRAMP #669

bricewge opened this issue Sep 13, 2016 · 4 comments

Comments

@bricewge
Copy link
Contributor

For example doing counsel-ag with a buffer containing the file/ssh:myserver:/etc/apt/sources.list will result on a search on /home/username/ on the localhost machine. This also appear when the buffer display a file opened as sudo on the localhost.

The expected behaviour would be to search from the opened file on the remote machine if ag is installed or as sudo if the file was openned as sudo.
@abo-abo
Copy link
Owner

abo-abo commented Sep 13, 2016

Does ag even work on a remote machine?

@bricewge
Copy link
Contributor Author

I don't thinks so. But it shouldn't be an issue since TRAMP give the ability to run commands on the remote box.
It looks like this behaviour is already present in ag.el.

@abo-abo
Copy link
Owner

abo-abo commented Sep 13, 2016

Please test, ag needs to be installed on the remote box.

@bricewge
Copy link
Contributor Author

You fixed it. And you were blazing fast.
Thanks a lot for your work en emacs packages, they are awesome !

@bricewge bricewge mentioned this issue Sep 23, 2017
Closed
@jeberger jeberger mentioned this issue Oct 9, 2017
Closed
jeberger added a commit to jeberger/swiper that referenced this issue Oct 10, 2017
@jeberger
counsel.el: Allow async commands on Tramp buffers
a6e15e6 
Makes `counsel--async-command` work on remote buffers. This removes
the need for the workaround introduced in `counsel-ag-function` with
abo-abo#669 and should fix similar issues in other commands or plugins.

Fixes abo-abo#1229
@jeberger jeberger mentioned this issue Oct 10, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abo-abo @bricewge