ivy.el (ivy--reset-state): Use copy-sequence when sorting collection #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids modifications of external data that could be caused by sorting with a collection function. Calling `copy-sequence` inside `ivy--reset-state` rather than requiring the collection function to do so has the advantage that it only happens if the collection is smaller than `ivy-sort-max-size`, which limits the performance impact.
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids modifications of external data that could be caused by
sorting with a collection function. Calling
copy-sequenceinsideivy--reset-staterather than requiring the collection function to doso has the advantage that it only happens if the collection is smaller
than
ivy-sort-max-size, which limits the performance impact.This is a follow up to #1592.