Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove swiperall magic number #1780

Closed
wants to merge 3 commits into from

Conversation

@mookid
Copy link
Contributor

commented Oct 10, 2018

Move counsel-more-chars-alist and counsel-more-chars to ivy.el.

I moved it there because it was reimplemented for swiper-all.

Unify the way counsel-more-chars is called, and remove a few remaining hardcoded values by the occasion.

this is one half of #1030

mookid added 3 commits Oct 10, 2018
Move counsel-more-chars-alist and counsel-more-chars to ivy.el.
* ivy.el:
  (ivy-more-chars): new function.
  (ivy-more-chars-alist): new variable.

* counsel.el:
  (counsel-more-chars): renamed function.
  (counsel-more-chars-alist): renamed variable.
swiper.el (swiper-all): use ivy-more-chars.
This way, the minimum number of chars before launching the completion is not hardcoded anymore.
@mookid

This comment has been minimized.

Copy link
Contributor Author

commented Oct 22, 2018

friendly ping :)

@mookid

This comment has been minimized.

Copy link
Contributor Author

commented Nov 18, 2018

friendly ping.

@abo-abo abo-abo closed this in c0a7efb Nov 18, 2018

@abo-abo

This comment has been minimized.

Copy link
Owner

commented Nov 18, 2018

Thanks.

@mookid mookid deleted the mookid:remove_swiperall_magic_number branch Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.