Check if ivy--done is accepting a string. #2200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some ivy commands (e.g. swiper-isearch) provide an int instead of a string. It won't work when the integer value is larger than unicode which cannot be converted to a char. ``` Debugger entered--Lisp error: (wrong-type-argument char-or-string-p 5557661) ivy--done(5557661) ivy-done() funcall-interactively(ivy-done) call-interactively(ivy-done nil nil) command-execute(ivy-done) read-from-minibuffer(...) ivy-read(...) swiper-isearch() ```
|
Thanks. |
astoff
pushed a commit
to astoff/swiper
that referenced
this pull request
Jan 1, 2021
Some ivy commands (e.g. swiper-isearch) provide an int instead of a string. It won't work when the integer value is larger than unicode which cannot be converted to a char. ``` Debugger entered--Lisp error: (wrong-type-argument char-or-string-p 5557661) ivy--done(5557661) ivy-done() funcall-interactively(ivy-done) call-interactively(ivy-done nil nil) command-execute(ivy-done) read-from-minibuffer(...) ivy-read(...) swiper-isearch() ``` Fixes abo-abo#2200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some ivy commands (e.g. swiper-isearch) provide an int instead of a
string. It won't work when the integer value is larger than unicode
which cannot be converted to a char.