Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if ivy--done is accepting a string. #2200

Closed
wants to merge 1 commit into from

Conversation

@amosbird
Copy link
Contributor

@amosbird amosbird commented Aug 16, 2019

Some ivy commands (e.g. swiper-isearch) provide an int instead of a
string. It won't work when the integer value is larger than unicode
which cannot be converted to a char.

Debugger entered--Lisp error: (wrong-type-argument char-or-string-p 5557661)
  ivy--done(5557661)
  ivy-done()
  funcall-interactively(ivy-done)
  call-interactively(ivy-done nil nil)
  command-execute(ivy-done)
  read-from-minibuffer(...)
  ivy-read(...)
  swiper-isearch()
Some ivy commands (e.g. swiper-isearch) provide an int instead of a
string. It won't work when the integer value is larger than unicode
which cannot be converted to a char.

```
Debugger entered--Lisp error: (wrong-type-argument char-or-string-p 5557661)
  ivy--done(5557661)
  ivy-done()
  funcall-interactively(ivy-done)
  call-interactively(ivy-done nil nil)
  command-execute(ivy-done)
  read-from-minibuffer(...)
  ivy-read(...)
  swiper-isearch()
```
@abo-abo abo-abo closed this in 560957f Aug 21, 2019
@abo-abo
Copy link
Owner

@abo-abo abo-abo commented Aug 21, 2019

Thanks.

astoff added a commit to astoff/swiper that referenced this issue Jan 1, 2021
Some ivy commands (e.g. swiper-isearch) provide an int instead of a
string. It won't work when the integer value is larger than unicode
which cannot be converted to a char.

```
Debugger entered--Lisp error: (wrong-type-argument char-or-string-p 5557661)
  ivy--done(5557661)
  ivy-done()
  funcall-interactively(ivy-done)
  call-interactively(ivy-done nil nil)
  command-execute(ivy-done)
  read-from-minibuffer(...)
  ivy-read(...)
  swiper-isearch()
```

Fixes abo-abo#2200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants