merge with development #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create account now requires the same password as the first account (all accounts should have the same password) (+1 squashed commit) Squashed commits: [ada3d02] Export Wif / Export Nep-2 (+1 squashed commit) Squashed commits: [7b76303] Export Account in NEP-2 format; Changing ReadPassword to use custom message;
* RocksDbRepository reach 42% cover * Rename abstract class ICrypto to Crypto. I'm sure this was once an interface but it's not anymore, threfore should not carry the prefix "I" that identify the interfaces. * fix some merge problems * Increase Server tests coverage to 94%. Black listed peers try to connect test * fix merge issues * * Remove protected fields from TestBase and replace with overload usage of the method RandomInt. * Small clean up on the UtCrypto * Create UtBlockchain and create first tests. more tests will be added soon! * fix issues from the merge * Adding testing information to the team Contributing page. * Small CleanUp the test class with properties that aren't been used anymore. * UtBlockChain: InitializeBlockchain_IsGenesisBlock_InitializeComplete * Firsts UtBlockProcessor tests * AddBlock tests added * * UtBlockProcessor: Run test * Fix an inverted if logic. The code only enter in the While loop if the cancellation was requested and should be the other way around. * Cleanup * Replace BlockProcessor dependency from Prompt and replace with IBlockPool * Remove unused properties from BlockProcessor * ContainsBlock method in BlockProcessor signature changed to Private because is not used anywhere else but internally * UtBlockProcessor - Loop test: When the received block is not the expected next. * Remove comment * Remove async modifier from methods that aren't implemented * . * Merge branch 'development' of https://github.com/aboimpinto/neo-sharp into development * Add test class, #301 * Write tests for Add method. #301 * Refactor the Block / BlockHeader in Signed and Unsigned objects (mutable and immutable). The intenstion of this refactor is to bring better readability of the code and remove logic code from the DTO. * Implement the UpdateHash methods in the creation of the Signed<object> * Signed and Unsigned strucuture return GenenisBlock * Draft of the BinaryCustomSeralization of TransactionBase * Revert "Remove stack logs (#321)" This reverts commit 34c676a. * Add BlockOperationsManager and WitnessOperationManager that will be resposable to Sign and Verify the block and the witness * Initial work, removing logic from the model objects and add it into Witness. Transaction, BlockHeader and Block OperationManager classes. In this classes the verify method will be implemented. #306, #307 * Cleanup and remove code that was not merged. * regreassion test for the case where the current block is null. This happen when the node start without genesis block. * Remove dependencies from BlockProcessor and remove BlockHeader references. BlockProcessor use only Block object. #350, #351 * now the Persist consider the genesis block for the case of start a node in a clean environment * * Remove IContainer from the MessageHandlerProxy. All handlers are now injected in the contructor * Strategy pattern used to find what MessageHandler should process the message. * Adding more debug messages and minor validations. remove comment code from MessageHandlerProxy * Remove comment code and clean up the usings * Replace Blockchain class dependencies with BlockchainContext. #426 * NeoSharp.SyncMVP removed * Remove NetworkStream.Dispose because it's already called called during the dispose. * refactor the Handle method to remove the foreach and nested if statement * add appsetting.neo-privnet.json * Missing cleanup when <object>OperationManager classes were introduced. * Cleanup the registration of the message handlers and MessageHandlerProxy has his own interface now. * Registration of MessageHandler is now singleton as requested by @osmirnov #427 * NeedPeerSync and IsSync properties added to BlockchainContext * MessageHandlers are type safe. The solution was to use an interface and an abstract class. #427 * remove example commented code * merge with development * merge with development
Squashed commits: [ee0bd01] Account alias Code improvements (+1 squashed commit) Squashed commits: [438524e] Account alias
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.