Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking: Drop legacy url.parse() NodeJS API #178

Merged
merged 2 commits into from
Sep 12, 2021
Merged

Breaking: Drop legacy url.parse() NodeJS API #178

merged 2 commits into from
Sep 12, 2021

Commits on Sep 12, 2021

  1. feat(compatibility): Drop deprecated url.parse() NodeJS-API. 

    BREAKING CHANGE: Unfortunately, there is no replacement for
the old API that is fully compatible. As a consequence this
change affects the way paths are being URL-encoded. Previously
all paths (relative or absolute) have been passed through
`url.parse(path).format()` and thereby got URL-encoded. With
this change encoded URLs are only created for option
`paths: "absolute"` in combination with a `baseUrl` other
than "/". The encoding may changed. Values for `baseUrl`
(if present) now *must* be "/" or *must* be URLs which
conform to WHATWG URL specification and which can be passed
as a 'base' parameter to Node's URL implemenation
(see https://docs.nodejs.org/api/url.html).
    @about-code
    about-code committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    a8312d5 View commit details
    Browse the repository at this point in the history

  2. test: New baseline.

    @about-code
    about-code committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    3135e92 View commit details
    Browse the repository at this point in the history