Breaking: Drop legacy url.parse() NodeJS API #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Unfortunately, there is no replacement for the old API that is fully compatible. As a consequence this change affects the way paths are being URL-encoded. Previously all paths (relative or absolute) have been passed through `url.parse(path).format()` and thereby got URL-encoded. With this change encoded URLs are only created for option `paths: "absolute"` in combination with a `baseUrl` other than "/". The encoding may changed. Values for `baseUrl` (if present) now *must* be "/" or *must* be URLs which conform to WHATWG URL specification and which can be passed as a 'base' parameter to Node's URL implemenation (see https://docs.nodejs.org/api/url.html).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.