Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant type attributes #1511

Merged
merged 1 commit into from
Jul 28, 2019
Merged

Remove redundant type attributes #1511

merged 1 commit into from
Jul 28, 2019

Conversation

Xeevis
Copy link
Contributor

@Xeevis Xeevis commented Jul 20, 2019

Type attributes on <script> and <link ref="stylesheet"> are redundant because currently set values are the default, which leads to warnings in the W3C Markup Validation Service

image


Quote from HTML 5.2 W3C Recommendation (§ 4.12.1. The script element)

The type attribute allows customization of the type of script represented:

Omitting the attribute, or setting it to a JavaScript MIME type, means that the script is a classic script, to be interpreted according to the JavaScript Script top-level production. Classic scripts are affected by the charset, async, and defer attributes. Authors should omit the attribute, instead of redundantly giving a JavaScript MIME type.

Quote from HTML 5.2 W3C Recommendation (§ 4.8.6.11. Link type "stylesheet")

The default type for resources given by the stylesheet keyword is text/css.

@hikalkan
Copy link
Member

Thanks @Xeevis for make it clean.

@hikalkan hikalkan merged commit c976590 into abpframework:dev Jul 28, 2019
@hikalkan hikalkan added this to the 0.19.0 milestone Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants