Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add email/username changed event #17990

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Add email/username changed event #17990

merged 4 commits into from
Oct 27, 2023

Conversation

salihozkara
Copy link
Member

@salihozkara salihozkara commented Oct 26, 2023

Description

When changing email/username, there may be scenarios where the old email/username is needed. For this reason, when the email/username changes, publish a distributed event containing the old email/username.

Breaking Change

Added IDistributedEventBus to IdentityUserManager's constructor

Checklist

  • I fully tested it as developer
  • I documented it (or no need to document or I will create a separate documentation issue)

@salihozkara salihozkara added this to the 8.0-preview milestone Oct 26, 2023
@EngincanV EngincanV requested review from maliming and removed request for EngincanV October 26, 2023 10:38
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #17990 (d383249) into dev (d5c3619) will increase coverage by 0.02%.
Report is 12 commits behind head on dev.
The diff coverage is 100.00%.

❗ Current head d383249 differs from pull request most recent head c0a7762. Consider uploading reports for the commit c0a7762 to get more accurate results

@@            Coverage Diff             @@
##              dev   #17990      +/-   ##
==========================================
+ Coverage   51.64%   51.66%   +0.02%     
==========================================
  Files        3052     3054       +2     
  Lines       95472    95501      +29     
  Branches     7615     7613       -2     
==========================================
+ Hits        49308    49343      +35     
+ Misses      44647    44643       -4     
+ Partials     1517     1515       -2     
Files Coverage Δ
...d/Volo/Abp/Identity/IdentityUserEmailChangedEto.cs 100.00% <100.00%> (ø)
...olo/Abp/Identity/IdentityUserUserNameChangedEto.cs 100.00% <100.00%> (ø)
...ty.Domain/Volo/Abp/Identity/IdentityUserManager.cs 67.50% <100.00%> (+5.51%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@maliming maliming merged commit a62e697 into dev Oct 27, 2023
3 checks passed
@maliming maliming deleted the salihozkara/emailChangedEvent branch October 27, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants